New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB connection in index.js not using port configured in env.sh #26

Closed

abrophy opened this issue Jul 6, 2017 · 1 comment

Contributor

abrophy commented Jul 6, 2017

If you attempt to configure a custom port in the env.sh file it is not respected by the mysql connection initiated in index.js .

The port key is missing from the config object passed to the createConnection method.

abrophy mentioned this issue

adds port to mysql createConnection call, fixes #26 #27

Merged

Contributor

dwightgunning commented Aug 17, 2017

Thanks for the pick up. Will review the PR shortly.

dwightgunning closed this as completed in

e0484b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment