Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks count numbers in the tags sidebar should depend on which view mode/tab is selected #170

Closed
ghost opened this issue Oct 1, 2015 · 5 comments
Assignees
Labels
bug low-hanging-fruit "Easy picks" suitable for new contributors to tackle priority:low reproducible-in-git Issues that affect the current dev version

Comments

@ghost
Copy link

ghost commented Oct 1, 2015

I'm using GTG from Git (version: r5170.a795d66-1). Currently count numbers are shown when you display the tags sidebar. The problem is those count numbers are identical when selecting any of the following three tabs: active tasks, workview tasks and closed tasks. In reality those count numbers are valid just for the active tasks tab and should be different when selecting the workview tasks tab or the closed tasks tab.

@nekohayo nekohayo added bug low-hanging-fruit "Easy picks" suitable for new contributors to tackle priority:low reproducible-in-git Issues that affect the current dev version labels Dec 12, 2019
@nekohayo
Copy link
Member

It would be great if you (or someone you know or someone looking at this) can provide a patch for this.

@nekohayo nekohayo changed the title Tasks count numbers should depend on which tab is selected Tasks count numbers in the sidebar should depend on which view mode/tab is selected Apr 17, 2020
@nekohayo nekohayo changed the title Tasks count numbers in the sidebar should depend on which view mode/tab is selected Tasks count numbers in the tags sidebar should depend on which view mode/tab is selected Mar 1, 2021
@odoood
Copy link
Contributor

odoood commented Sep 6, 2021

Is this something that should be handled separately from #560 ? I'd like to take on this task if so, assuming this is still valid

@Neui
Copy link
Contributor

Neui commented Sep 6, 2021

What do you mean with "handled separately"? From what I can see they're different issues (but on the same component), but a problem is how you would "present" it to the user (like how would they choose?). I guess a "fix" for this issue could build upon a fix for that other issue, if it lays out some foundation (such as the UI issue), but this isn't a requirement.

I guess you could just always show the numbers of the currently selected view rather than of all tasks since if they want to do the latter they could just press the "all Tasks" tag.
Good luck figuring out a good way to implement such thing in liblarch+gtg, last time I looked into it (for an different issue) it wasn't great to deal with.

@odoood
Copy link
Contributor

odoood commented Sep 6, 2021

Since they're on the same component and related wasn't sure whether the approach to addressing this would be decided in conjunction with the other.

My thought for this is to have the task counts for both the selected view and all tasks for a given tag displayed, with the total in parenthesis next to the selected count. E.g. "My Task 5 (10)" for 5 of the selected view and 10 total of tag "My Task"

Haven't dealt with liblarch so thanks for the heads-up.

@nekohayo
Copy link
Member

This was implemented in f336e44 and d0245fc (and a couple of older commits). However, it is sometimes buggy, see #1023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug low-hanging-fruit "Easy picks" suitable for new contributors to tackle priority:low reproducible-in-git Issues that affect the current dev version
Projects
None yet
Development

No branches or pull requests

4 participants