Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new and pathetic "icon" issue barely worth even worrying about #904

Closed
primal-buddhist opened this issue Jun 7, 2022 · 5 comments · Fixed by #894
Closed

A new and pathetic "icon" issue barely worth even worrying about #904

primal-buddhist opened this issue Jun 7, 2022 · 5 comments · Fixed by #894

Comments

@primal-buddhist
Copy link

  1. I edit a tag
  2. I click on the icon
  3. I select, say, a person with a stethoscope
  4. And a generic head appears
  5. Or I select a red heart with a bandage
  6. And a black heart with no bandage appears

Some icons, maybe 70%, are good, but many don't work - flags for eg, or people with trades.

I am on Fedora WS 36, GTG 0.6

@nekohayo
Copy link
Member

nekohayo commented Jun 7, 2022

Maybe something is going on with the GTK emoji selector where your mouse clicks don't match the icon underneath? I've seen it happen elsewhere, especially on laggy social media websites with their own emoji picker, that if you move the mouse you have to wait for the preselection to arrive under the icon before clicking it... but I haven't experienced that problem with the GTK emoji picker.

@nekohayo nekohayo added priority:low needinfo We need more info to solve the issue, or we can't fix it. labels Jun 7, 2022
@primal-buddhist
Copy link
Author

primal-buddhist commented Jun 7, 2022

Even if I use the keyboard to select it happens

It doesn't pick the one next door, it sort of substitutes one quite like it.

In the case of "people with trades" it just selects a head like the head but without any of the tools or stethoscopes. It selects the right gender but the jumper will change colour. Or there will be a monochrome version.

My gut feeling is that there are two sets, mapped to each other, but I don't know enough about the underlying system to say how that is possible. So on the right there is the "recently used emoji" list and I can see that it is the green jumpered man but on the left, in the gtg spot, you can see the orange jumpered man. Like the library in GTG is mapped to the library in the picker but with a similar but not identical set.

See below - the first icon in green is the one I am selecting

Screenshot from 2022-06-07 14-57-17

@Neui
Copy link
Contributor

Neui commented Jun 7, 2022

Some emojis are created by combining other emojis. For flags for example, they are just two special characters, it is up to the system/font to for example make regional indicator symbols "DE" to 🇩🇪.

It seems that GTG is chopping off any additional emojis. For example, I just get a "D" when I select 🇩🇪. Looking a bit it seems the max-length-property of the invisible Gtk.Entry seems to be the cause; Upping the limit (at least via the GTK inspector) makes at least the flag work (and applies correctly as expected).

@kocio-pl
Copy link
Contributor

I guess this might be the same as #817.

@diegogangl
Copy link
Contributor

This is fixed in the gtk4 port (#894). It will take quite a while to hit master though
Screenshot from 2022-06-19 20-05-38

@nekohayo nekohayo added bug and removed needinfo We need more info to solve the issue, or we can't fix it. labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants