Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the PDF / PocketMod export plugin to get rid of the pdftk-java dependency #984

Open
nekohayo opened this issue Sep 8, 2023 · 4 comments
Labels
dependencies Pull requests that update a dependency file enhancement patch-or-wont-happen Core maintainers would like this, but lack time/energy. Contribute a patch or it won't happen. plugins Plugins and extra backends priority:low

Comments

@nekohayo
Copy link
Member

nekohayo commented Sep 8, 2023

It turns out that by using pdftk we accidentally depend on Java, which is hilarious and sad at the same time 🫠

Indeed, the pdftk project reportedly rewrote their codebase to Java some years ago. I had never noticed because the GTG package had disappeared from Fedora, but it actually exists in Debian, so whoever installs Debian's/Ubuntu's GTG package gets pdftk-java pulled in as part of the dependencies. I'm not even sure it actually works with that pdftk-java thing installed, in practice…

This is not urgent, but eventually after 0.7 is done (see #737) and released, as part of #974 it would be a "nice thing to have" to get rid of this dependency. Maybe by doing MarkDown export as a first-class citizen instead of PDF, and leaving PDF generation to the various Markdown conversion tools?

@nekohayo nekohayo added enhancement priority:low patch-or-wont-happen Core maintainers would like this, but lack time/energy. Contribute a patch or it won't happen. plugins Plugins and extra backends dependencies Pull requests that update a dependency file labels Sep 8, 2023
@Neui
Copy link
Contributor

Neui commented Sep 8, 2023

It seems Debian marks pdftk-java as a dependency instead of something else (recommends/suggests/enhances), so maybe that could be changed in the meantime.

@nekohayo
Copy link
Member Author

nekohayo commented Sep 8, 2023

Maybe @fbriere is the one to notify about the Debian package's dependencies property, or would know who to notify or could file a bug on Debian…

@ploum
Copy link
Contributor

ploum commented Sep 9, 2023

I submitted a bug to debian about it.

There’s already a different albeit related one: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050453

@ploum
Copy link
Contributor

ploum commented Sep 9, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement patch-or-wont-happen Core maintainers would like this, but lack time/energy. Contribute a patch or it won't happen. plugins Plugins and extra backends priority:low
Projects
None yet
Development

No branches or pull requests

3 participants