App Submission: nolooking #229
Conversation
There was a problem hiding this comment.
@nickfarrow Thanks for the app submission! Would you be able to give me write access so I can push quickly some changes?
A few things we can do is:
- Drop
exports.sh - Add Docker image digest
- Add app submission metadata to the app manifest (
umbrel-app.yml)
Is there also some reason that you have disabled authentication within the App Proxy?
There was a problem hiding this comment.
@nickfarrow Thanks for the PR to submit nolooking into the app store!
There are a few small things that I noted:
- There are no cache (
Cache-Control) headers set for your static assets. I tested nolooking on a server on the other side of the earth, so we could improve (repeat) load performance a little bit with caching here. This will also help with access over Tor (which is pretty slow). - If I click "Generate Funding Request" with no input, then the backend gives me a
502: Bad Gateway, with this error in the container logs:
thread 'tokio-runtime-worker' panicked at 'invalid request: Custom("cannot parse integer from empty string")', src/http.rs:78:76
However, I note that this is early Alpha software and will want to get nolookng in front of users to quickly iterate.
This is approved from me!
@mayankchhabra Would you be able to work on the assets for the App Store please?
|
Thank you @nevets963 for your changes!! Made an issue for the empty input 502 payjoin/nolooking#41 Cache sounds like a good idea, especially for tor as you said. Looking into this now. We will get both of them into a new image. Let me know if there is anything else! |
|
Bumped version to include some minor changes to UI and backend fixes. Also added a disclaimer to app description. The empty input field bug has been alleviated by requiring input for them for now (we are yet to add a [-] row button, todo). We are not yet caching images |
|
In the latest image I have included a commit from payjoin/nolooking#44 which adds Cache-control. It also adds favicon and some more recent styling. |
|
What an awesome use case for P2EP! Nice work packaging nolooking, @nickfarrow. Also great to see the initial response on Twitter — looks like it's going to be a hit among the users! There were some issues with the icon's SVG rendering, so we tried to recreate a modified version of it with a splash of colors and fun. Also added a halloween-themed background to the screenshots :) You can check them out here: getumbrel/umbrel-apps-gallery#16 Let us know if you're happy with how they look! Re
Yes, you can change the gallery images and app icon at any point in the future by simply opening a PR on the getumbrel/umbrel-apps-gallery repo, and it should be updated for all users instantly. |
|
Awesome @mayankchhabra , love the updated images and I thing the screenshots look fantastic. Resolved your feedback in the latest commit. Thank you so much! So excited to push this out to umbrel users |
|
The graphics were merged in and tested within the Umbrel UI. That looked all good! So, nolooking is now merged 🚀 😄 |
|
@mayankchhabra the icon you made is AWESOME 🙌 May the nolooking authors have the rights to the image? It'd be great to post to get the word out now that we're in the store, and we'd like your blessing to use it everywhere |
|
Hell yeah! I'm glad you like it @DanGould! 🙌 Yes, please feel free to use the icon anywhere and however, with or without modification, for any commercial or non-commercial purpose. 🤝 |
Co-authored-by: Steven Briscoe <me@stevenbriscoe.com> Co-authored-by: Mayank Chhabra <mayank@umbrel.com>
App Submission
nolooking
Nolooking leverages Pay-to-Endpoint (payjoin) to negotiate a channel open for your lightning node, initiated by any BIP78 supporting wallet. You can open multiple lightning nodes in a single payment, improving privacy, saving on transaction fees and wait time. For more, see this article about Lightning Powered PayJoin!
Icon:
https://svgur.com/s/ngG
I have tested my app on:
I successfully opened two channels in one transaction entirely over tor, using sparrow wallet.
A few of us have had trouble getting
umbrel-devrunning (used to work for me but it no longer likes my environment), will keep trying..Is it possible to change our icon and images at a later date? We will have a more styled logo and many more pages coming soon!