Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Kubernetes deployment.yaml file has two issues #216

Closed
CoreyH opened this issue Oct 6, 2023 · 2 comments
Closed

[BUG] Kubernetes deployment.yaml file has two issues #216

CoreyH opened this issue Oct 6, 2023 · 2 comments

Comments

@CoreyH
Copy link

CoreyH commented Oct 6, 2023

I have spent a few days working out the kinks deploying Zep to GCP Kubernetes Engine and I found two major issues that I think I have solutions for. I was going to submit a pull request, but wanted to check here first in case I was missing something.

First, there is seemingly a Typo in the deployment.yaml file. It should be ZEP_STORE_POSTGRES_DSN not ZEP_MEMORY_STORE_POSTGRES_DSN

Second, I had all kinds of trouble with the healthcheck and the solution was to remove host: 127.0.0.1 entirely from the healthcheck and that solved the issue for me.

And not a bug, but in case someone else is looking for this, I was able to use a managed SQL Postgres instance instead of the docker/k8s based one and that seems to be working just fine. I did enable the pgvector extension, but it supports it with no apparent issues.

Thanks all,
-Corey

@danielchalef
Copy link
Member

danielchalef commented Oct 6, 2023

Thanks, @CoreyH. Yes - the k8 template was inadvertently not updated when the DSN key changed. A PR would be appreciated!

It's fine to remove the health check. We can leave that as an exercise to the implementor.

Zep definitely works with managed Postgres instances. The only caveat is that not all providers have upgraded to pgvector v0.5 yet, so HNSW indexing may not be available.

@danielchalef
Copy link
Member

I've updated the k8s deployment to fix the above. See #227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants