Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing zola build with option: "external_links_target_blank = true" #2548

Closed
hannes-sistemica opened this issue Jun 25, 2024 · 3 comments
Closed

Comments

@hannes-sistemica
Copy link

Bug Report

I have been running a static site without issues with Zola 0.18.0 and recently upgraded to 0.19.1. Then I got the error:

Error: Failed to build the site
Error: TOML parse error at line 12, column 1
   |
12 | external_links_target_blank = true
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
unknown field `external_links_target_blank`, expected one of `base_url`, `theme`, `title`, `description`, `default_language`, `languages`, `translations`, `generate_feeds`, `feed_limit`, `feed_filenames`, `hard_link_static`, `taxonomies`, `author`, `compile_sass`, `minify_html`, `build_search_index`, `ignored_content`, `ignored_static`, `mode`, `output_dir`, `preserve_dotfiles_in_output`, `link_checker`, `slugify`, `search`, `markdown`, `extra`

I temporarely disabled/commented out the line to get my page online, but obviously I would like to have external links opened in new pages (which is now disabled)

Environment

Zola version: 0.19.1

Expected Behavior

Page should have been build.

Current Behavior

See above, page does not built

Step to reproduce

Add "external_links_target_blank = true" to the config.toml

@Keats
Copy link
Collaborator

Keats commented Jun 25, 2024

This means the field is currently at the top level while it should be nested in a [markdown] section in the config.

@hannes-sistemica
Copy link
Author

hannes-sistemica commented Jun 25, 2024

Ok, thanks - didn't see that properly in docs. Was there a change, as it worked before?
With that change it works!

@Keats
Copy link
Collaborator

Keats commented Jun 25, 2024

It didn't change so I'm not sure how it worked with you since it was ignored. All that changed was erroring on unexpected fields in the config and front-matter

@Keats Keats closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants