New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] emojis #292
Comments
I wouldn't use it so if someone wants it it would have to come from a user contribution after the markdown rewrite is working |
The following crate would be needed for this purpose: https://github.com/jiri/rust-emojicons |
The crate doesn't look maintained but is very small/self-contained. |
rust-unic has a good emjoi support through its unic-emoji component. |
+1 for this feature |
I think this feature can be implemented using gh-emoji crate. To make it work, we could just introduce a few new lines in components/rendering/src/markdown.rs for the normal text (non-code block) text rendering. (and of course, make emoji support configurable in config). PR. @Keats If I have spare time, I'll try to implement this tomorrow and push the new PR |
It would be great to have a list of supported emojis. https://github.com/github/gemoji/blob/5361b5639f004a11221fb34dad272d0093ec3239/db/emoji.json is the data file, but it would be great to have a definite list that can be viewed. Is there one? If not, what do you think if CI would generate the list (using |
Not right now but I'd take a PR to include it in the docs as a one-off. Probably not worth making it automatic in the CI, just an example bin that outputs the list is fine |
Hugo provides this feature. I know development time could be spent on more important features. But, since the markdown renderer going through a re-write and implementing this feature might not be that hard, it would be great to see it in Gutenberg in the near future.
Thanks!
The text was updated successfully, but these errors were encountered: