urllib3 doesn’t raise ReadTimeoutError when monkey patched.

[karanlyons]

Gevent v1.1b3 with Python 2.7.6.

nc -l 1337 # Listen on 1337 and keep the connection open.

Without Gevent:

import urllib3
http = urllib3.PoolManager()
r = http.request('GET', 'http://localhost:1337/', timeout=1)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.7/dist-packages/urllib3/request.py", line 75, in request
    **urlopen_kw)
  File "/usr/lib/python2.7/dist-packages/urllib3/request.py", line 88, in request_encode_url
    return self.urlopen(method, url, **urlopen_kw)
  File "/usr/lib/python2.7/dist-packages/urllib3/poolmanager.py", line 155, in urlopen
    response = conn.urlopen(method, u.request_uri, **kw)
  File "/usr/lib/python2.7/dist-packages/urllib3/connectionpool.py", line 557, in urlopen
    body=body, headers=headers)
  File "/usr/lib/python2.7/dist-packages/urllib3/connectionpool.py", line 414, in _make_request
    self, url, "Read timed out. (read timeout=%s)" % read_timeout)
urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='localhost', port=1337): Read timed out. (read timeout=1)

With Gevent:

from gevent import monkey
monkey.patch_socket()

import urllib3

http = urllib3.PoolManager()
r = http.request('GET', 'http://localhost:1337/', timeout=1) # Hangs indefinitely.

[jamadden]

Can you simplify the scenario to not use a third-party library? The presence of a third-party library makes things much more complicated.

[karanlyons]

I’ll try to come up with a bare socket example that isn’t doing anything different. For what it’s worth, you can wrap your request in a gevent.Timeout context to get an ersatz read timeout (it won’t actually be for just the read, but the entire connection), but ideally that wouldn’t be needed.

[karanlyons]

Here’s the behavior with a bare socket:

nc -l 1337 # Listen on 1337 and keep the connection open.

Without Gevent:

>>> import socket
>>> sock = socket.create_connection(('localhost', 1337), 1)
>>> fp = sock.makefile('rb', 0)
>>> fp.read()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/Cellar/python/2.7.10/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 355, in read
    data = self._sock.recv(rbufsize)
socket.timeout: timed out

With Gevent:

>>> from gevent import monkey
>>> monkey.patch_socket()
>>> 
>>> import socket
>>> sock = socket.create_connection(('localhost', 1337), 1)
>>> fp = sock.makefile('rb', 0)
>>> fp.read() # Hangs indefinitely.

Note that sock.recv() does the right thing in both cases (raising socket.timeout), but using a file object (as httplib and all its descendants do) causes the read to hang indefinitely when socket is monkey patched.

[jamadden]

Thanks for the report. I can reproduce this under Python 2, but I can't reproduce it under Python 3 (the expected timeout is raised under Python 3). The expected timeout is also raised for Python 2 with gevent 1.0.2, so this is a regression somewhere.