fix(version): Version check now removes "v" first character from tag (#…

…129)

This avoid version check to always warn a new version is available

Close #129

ddb/__main__.py

@@ -32,7 +32,7 @@
 from ddb.phase import phases
 from ddb.registry import Registry, RegistryObject
 from ddb.service import services
-from ddb.utils.release import ddb_repository, get_lastest_release_version
+from ddb.utils.release import ddb_repository, get_latest_release_version
 from ddb.utils.table_display import get_table_display
 from ddb.feature.core import ConfigureSecondPassException
 
@@ -374,7 +374,7 @@ def main(args: Optional[Sequence[str]] = None,
                     ]
                 ]
 
-                last_release = get_lastest_release_version()
+                last_release = get_latest_release_version()
                 if last_release and __version__ < last_release:
                     version_content.append([
                         '',
@@ -440,7 +440,7 @@ def _check_for_update():
     today = date.today()
 
     if last_check is None or last_check < today:
-        last_release = get_lastest_release_version()
+        last_release = get_latest_release_version()
         if last_release and __version__ < last_release:
             header = 'A new version is available : {}'.format(last_release)
             content = [[

ddb/utils/release.py

@@ -3,14 +3,17 @@
 ddb_repository = 'gfi-centre-ouest/docker-devbox-ddb'
 
 
-def get_lastest_release_version():
+def get_latest_release_version():
     """
     Retrieve latest release version from GitHub API
-    :return: the json flux from GitHub API
+    :return: Version from tag_name retrieved from GitHub API
     """
     response = requests.get('https://api.github.com/repos/{}/releases/latest'.format(ddb_repository))
     try:
         response.raise_for_status()
-        return response.json().get('tag_name')
+        tag_name = response.json().get('tag_name')
+        if tag_name and tag_name.startswith('v'):
+            tag_name = tag_name[1:]
+        return tag_name
     except:  # pylint:disable=bare-except
         return None