New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

does webhook secret validation work? #71

Closed

tooptoop4 opened this issue Apr 27, 2022 · 2 comments

tooptoop4 commented Apr 27, 2022 •

edited

Loading

https://github.com/argoproj/argo-events/blob/340627059538af49f095e497fdef1b9e888f393d/eventsources/sources/bitbucketserver/start.go#L290 references this lib
but curl requests to the webook still succeed without any webhook secret passed

i couldn't see something like https://github.com/go-playground/webhooks/blob/v5.17.0/bitbucket-server/bitbucketserver.go#L129-L141

Author

tooptoop4 commented Nov 19, 2022

doesn't work

tooptoop4 closed this as completed

Owner

gfleury commented Nov 19, 2022

Hey @tooptoop4 some endpoints are indeed missing some details. Not sure if this is one of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment