Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis started to fail #46

Closed
qnighy opened this issue Mar 2, 2018 · 8 comments · Fixed by #86
Closed

Travis started to fail #46

qnighy opened this issue Mar 2, 2018 · 8 comments · Fixed by #86
Labels

Comments

@qnighy
Copy link
Contributor

qnighy commented Mar 2, 2018

Currently #44 (build #929) and #45 (build #930) fail (for seemingly the same reasons). As #44 is a trivial change, they must be spurious errors.

I couldn't figure out the exact cause. Seems to be related to core_kernel.

@mt-caret
Copy link

mt-caret commented Mar 2, 2018

I get the same error message as https://travis-ci.org/gfngfn/SATySFi/builds/348081919 while packaging SATySFi for Nix; I would love to know how to fix it.

Logs:
https://gist.github.com/mt-caret/26689bcc94a81274081ff3927fa1d9c5

I'm at 042a8aa and I'm getting this error since 26aa766 so the error might be originating somewhere else...

@qnighy
Copy link
Contributor Author

qnighy commented Mar 2, 2018

@mt-caret #47 might help you.

@qnighy
Copy link
Contributor Author

qnighy commented Mar 2, 2018

I tried to bisect dune (formerly jbuilder) between 1.0+beta17 and 1.0+beta18 with the following test script:

opam reinstall -y jbuilder
opam reinstall -y core_kernel

Bisect reported ocaml/dune@9e4cc84 as the first bad commit.

@mt-caret
Copy link

mt-caret commented Mar 2, 2018

I can confirm, #47 indeed fixes the error. Thank you!

An upstream bug, then?

@qnighy
Copy link
Contributor Author

qnighy commented Mar 2, 2018

Probably. I'm investigating further.

@qnighy
Copy link
Contributor Author

qnighy commented Mar 3, 2018

The bisect procedure above was wrong; now I pinned jbuilder and satysfi to local repos and bisected on jbuilder with the following script:

opam reinstall -y jbuilder
opam reinstall -y core_kernel
opam reinstall -y satysfi

Bisect reported ocaml/dune@b383828 as the first bad commit.

@mt-caret
Copy link

mt-caret commented Mar 3, 2018

There's a PR that might be addressing the issue: ocaml/dune#567

@qnighy
Copy link
Contributor Author

qnighy commented Mar 3, 2018

Confirmed locally that the current master (ocaml/dune@e4aac2d) does not cause the Core_kernel__ problem. I think it is good to pin to 1.0+beta17 until 1.0+beta19 is released.

@gfngfn gfngfn added the bug label Mar 3, 2018
qnighy added a commit to qnighy/SATySFi that referenced this issue Mar 3, 2018
nyuichi added a commit to nyuichi/homebrew-satysfi that referenced this issue Mar 3, 2018
yasuo-ozu pushed a commit to yasuo-ozu/aur-satysfi-git that referenced this issue Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants