Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a strong name to the package #116

Closed
ycrumeyrolle opened this issue Mar 13, 2020 · 1 comment · Fixed by #117
Closed

Add a strong name to the package #116

ycrumeyrolle opened this issue Mar 13, 2020 · 1 comment · Fixed by #117
Assignees
@gfoidl
Milestone
v1.1.0

Comments

@ycrumeyrolle
Copy link
Contributor

In order to allow integration to applications or packages that are themself with a strong name, this package should be signed.
THis is generating the following warning message:
CSC : warning CS8002: Referenced assembly 'gfoidl.Base64, Version=1.0.761.1, Culture=neutral, PublicKeyToken=null' does not have a strong name.

https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming
@gfoidl gfoidl added this to the v1.1.0 milestone Mar 13, 2020
@gfoidl gfoidl self-assigned this Mar 13, 2020
@gfoidl
Copy link
Owner

gfoidl commented Mar 13, 2020

Good idea (although I don't like strong names 😉). Will address this in the next days.

@gfoidl gfoidl mentioned this issue Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfoidl gfoidl

Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Added strong name signing gfoidl/Base64
2 participants
@ycrumeyrolle @gfoidl