Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace int-math with uint-math #125

Closed
gfoidl opened this issue Mar 19, 2020 · 0 comments · Fixed by #127
Closed

Replace int-math with uint-math #125

gfoidl opened this issue Mar 19, 2020 · 0 comments · Fixed by #127
Labels
code-quality / tests perf
Milestone
v1.1.0

Comments

@gfoidl
Copy link
Owner

gfoidl commented Mar 19, 2020

E.g.

Base64/source/gfoidl.Base64/Internal/Base64EncoderImpl.cs

Line 106 in 90470c2

int numWholeOrPartialInputBlocks = (sourceLength + 2) / 3;

With uint the JIT can generate better code (but only where safe).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality / tests perf
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Use uint for division instead of int gfoidl/Base64
1 participant
@gfoidl