Properly handle projects/workspaces with spaces in the name

[gfontenot]

We aren't doing this correctly everywhere right now.

[gfontenot]

I think right now we're just messing it up for the run actions.

[sharplet]

This should include scheme names with spaces, too.

[gfontenot]

I wonder if someone like @gabebw or @pbrisbin have ideas here. We're passing the scheme and workspace/project to the run_ios_app script correctly, and then using $@ to pass those to the xcodebuild command, but it seems like the quotes are getting stripped somewhere along the line.

[gfontenot]

More specifically:

• We're creating the command here.
• s:build_target_with_scheme is calling out to s:scheme
• s:cli_args uses shellescape to escape the values properly
• We're passing the arguments to xcodebuild with $@

My assumption is that by the time the flags get to $@ they have lost the quotes, but I'm not sure how to fix that.

[gabebw]

The part that jumps out to me is that in your last link, $@ isn't quoted like "$@".

I wrote about the differences, but the idea is that $@ without quotes doesn't respect quotes even if the arguments are quoted.

[gabebw]

shellcheck agrees:

$ shellcheck run_ios_app 

In run_ios_app line 5:
build_path=$(xcodebuild -showBuildSettings $@ 2>/dev/null | egrep "\bBUILD_DIR\b" | sed -E "s/[[:space:]]+BUILD_DIR = //")
                                           ^-- SC2068: Double quote array expansions to avoid re-splitting elements.

[gabebw]

shellcheck found the same problem in some of the other scripts in bin. This is the full output:

$ shellcheck bin/*

In bin/list_schemes.sh line 5:
xcrun xcodebuild -list $@ 2>/dev/null \
                       ^-- SC2068: Double quote array expansions to avoid re-splitting elements.


In bin/run_ios_app line 5:
build_path=$(xcodebuild -showBuildSettings $@ 2>/dev/null | egrep "\bBUILD_DIR\b" | sed -E "s/[[:space:]]+BUILD_DIR = //")
                                           ^-- SC2068: Double quote array expansions to avoid re-splitting elements.


In bin/run_mac_app line 3:
build_path=$(xcodebuild -showBuildSettings $@ 2>/dev/null | egrep "\bBUILD_DIR\b" | sed -E "s/[[:space:]]+BUILD_DIR = //")
                                           ^-- SC2068: Double quote array expansions to avoid re-splitting elements.


In bin/use_simulator.sh line 5:
xcrun xcodebuild -showBuildSettings $@ 2>/dev/null \
                                    ^-- SC2068: Double quote array expansions to avoid re-splitting elements.

[gfontenot]

Ah, I didn't realizing that quoting $@ worked that way. Neat. I should look into getting ci set up to run shellcheck against PRs.

[pbrisbin]

I should look into getting ci set up to run shellcheck against PRs.

You could also use Code Climate :D

https://codeclimate.com/github/pbrisbin/aurget/issues

[pbrisbin]

In addition to the shellcheck engine, there's also vint. I'm not sure how good it is, but worth a shot.