You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I am trying to use this plugin instead of pytest-isort.
For me looks more logical to use a flake8 plugin to check imports rather than a plugin for your test runner.
But, I am finding one issue with flake8-isort. Its output is not as good as pytest-isort:
_________________________________ isort-check __________________________________
ERROR: /Users/sobolev/Documents/github/wemake-python-styleguide/wemake_python_styleguide/checker.py Imports are incorrectly sorted.
from ast import Module
from typing import Generator
+
from flake8.options.manager import OptionManager
from wemake_python_styleguide import constants
from wemake_python_styleguide.options.config import Configuration
from wemake_python_styleguide.types import (
+ CheckerSequence,
CheckResult,
- CheckerSequence,
ConfigurationOptions,
)
+from wemake_python_styleguide.version import version
from wemake_python_styleguide.visitors.ast.complexity.counts import (
MethodMembersVisitor,
ModuleMembersVisitor,
)
-from wemake_python_styleguide.version import version
from wemake_python_styleguide.visitors.ast.complexity.function import (
FunctionComplexityVisitor,
)
Versus an output from flake8-isort:
/Users/sobolev/Documents/github/wemake-python-styleguide/wemake_python_styleguide/checker.py:5:1: I003 isort expected 1 blank line in imports, found 0
/Users/sobolev/Documents/github/wemake-python-styleguide/wemake_python_styleguide/checker.py:11:1: I001 isort found an import in the wrong position
/Users/sobolev/Documents/github/wemake-python-styleguide/wemake_python_styleguide/checker.py:18:1: I001 isort found an import in the wrong position
The first one shows the direct problem, while the second one just shows the line number of the incorrect import.
Thanks!
The text was updated successfully, but these errors were encountered:
Hi, I am trying to use this plugin instead of
pytest-isort
.For me looks more logical to use a
flake8
plugin to check imports rather than a plugin for your test runner.But, I am finding one issue with
flake8-isort
. Its output is not as good aspytest-isort
:Versus an output from
flake8-isort
:The first one shows the direct problem, while the second one just shows the line number of the incorrect import.
Thanks!
The text was updated successfully, but these errors were encountered: