You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In a project I'm working on (can provide link if you need it) we have a pipeline setup to run flake8, but flake8-isort doesn't seem to run correctly as it doesn't detect isort failures. Running isort only works fine, so I guess its the plugin 😄
Isort config (.isort.cfg)
[settings]
profile = black
force_single_line = true
Flake8 config (.flake8)
[flake8]
count = true
ignore =
A002, # Argument is shadowing a python builtin.
A003, # Class attribute is shadowing a python builtin.
CFQ002, # Function has too many arguments.
D102, # Missing docstring in public method.
D105, # Magic methods not having a docstring.
D412, # No blank lines allowed between a section header and its content
E402, # Module level import not at top of file (isn't compatible with our import style).
IFSTMT001 # "use a oneliner here".
T101, # TO-DO comment detection (T102 is FIX-ME and T103 is XXX).
W503, # line break before binary operator.
W504, # line break before binary operator (again, I guess).
S101, # Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
# F401: unused import.
# F403: cannot detect unused vars if we use starred import
# FS003: f-string missing prefix.
# R102: unnecessary parenthesis on raised exception (raises false positives in places)
# S106: posible hardcoded password (we dont care about this in the tests)
# D106, D104, D103, D101, D100: Missing docstring in public function/class/module (ignore in tests)
per-file-ignores =
hikari/__init__.py: F401,F403
hikari/events/__init__.py: F401,F403
hikari/utilities/routes.py: FS003
hikari/utilities/date.py: FS003
hikari/impl/stateless_cache.py: R102
tests/hikari/*: FS003,S106,D106,D104,D103,D101,D100
max-complexity = 20
# TODO reset to 100 again if possible.
max-function-length = 130
# Technically this is 120, but black has a policy of "1 or 2 over is fine if it is tidier", so we have to raise this.
max-line-length = 130
show_source = False
statistics = False
accept-encodings = utf-8
docstring-convention = numpy
@davfsa thanks for using flake8-isort and on top of it reporting the problems you find with it, so we can improve it 👍 ✨
On to topic: it's a bit hard to debug, which kind of pipeline is that? 🤔 some sort of CI integration I guess?
Can you run the steps on that pipeline locally and the problem does happen as well? 🤔 it might be the way the environment is set on the pipeline that makes it not work? 🤔
Sorry, that I never catch up again on this issue, but since there was no further input, I'm closing this. Please reopen if you still have the same problem.
In a project I'm working on (can provide link if you need it) we have a pipeline setup to run flake8, but
flake8-isort
doesn't seem to run correctly as it doesn't detect isort failures. Running isort only works fine, so I guess its the plugin 😄Isort config (.isort.cfg)
Flake8 config (.flake8)
Flake8 plugins
The text was updated successfully, but these errors were encountered: