-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting require.js configs #60
Comments
With the AMDclean 2.3.0 release, the Unfortunately, the way moment.js is written, this AMDclean update does not release the global Thanks and let me know if you have any questions! |
Any update on this, from either side? I'm having a heap of problems with RequireJS, AmdClean and Moment. On some build boxes, everything works as expected, and on identical other boxes, get moment is undefined all over the place. On the boxes that work, amdclean yeilds the following:
And on non-working builds:
As you can see, the working version wraps the moment variable in underscores, Why does AmdClean does this on some boxes and not on others? Is there a way to ensure it is wrapped? |
I'm running into similar issues while trying to use the RequireJS Optimizer and AMDclean 2.7.0 to bundle moment.js 2.10.6 into a project. My project is wrapped with a UMD wrapper which is very similar to the one that appears in moment.js. When moment.js is bundled into the built file, I end up seeing It looks like this could be related to moment/moment#1574 or some of the other issues mentioned in it? @gfranko or @ichernev, I'm curious if either of you have any suggestions or insights? Thanks! |
I'm trying to bundle moment.js with my project without it polluting the global scope.
I'm using amdclean to clean up all the AMD references and require in moment in the correct places throughout my bundled file.
To get moment running I need to supply the following config to requirejs:
Source: http://momentjs.com/docs/#/use-it/require-js/
How can I get this working with AMDClean?
Here is some sample code I ripped from moment.js
And this is what amdclean gives me
The text was updated successfully, but these errors were encountered: