Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use the same ids on select tags without id #8

Closed
tvdeyen opened this issue Jun 24, 2012 · 3 comments
Closed

Do not use the same ids on select tags without id #8

tvdeyen opened this issue Jun 24, 2012 · 3 comments
Assignees
Labels

Comments

@tvdeyen
Copy link
Contributor

tvdeyen commented Jun 24, 2012

If the select tag does not have an id attribute you use the same id for all the generated select boxes.
You should use unique ids.

@gfranko
Copy link
Owner

gfranko commented Jun 24, 2012

I agree that if there are more than one select boxes on the page that are you using SelectBoxIt, the dynamically generated DOM elements should not share the same id's. Instead of generating unique ids, I think a better solution would be to just supply a class name instead of an id.

@gfranko gfranko closed this as completed Jun 25, 2012
@yojeek
Copy link

yojeek commented Oct 10, 2012

Is it fixed?

@gfranko
Copy link
Owner

gfranko commented Oct 10, 2012

Good catch! This issue had fallen through the cracks, but it should be fixed now.

If you do not have an id attribute on your select box, then SelectBoxIt will supply a class name instead of a "unique" id.

Note: If you do have an id attribute on your select box, then SelectBoxIt will supply both a "unique" id and class name.

@ghost ghost assigned gfranko Dec 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants