Change scrollHistory to use window.location.replace #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user visited a page with scrollHistory on, and scrolled down the page, in order to get back to the previous page, they would have had to click back in their browser many, many times. This commit fixes that, so that as the user scrolls, the hash is added to the URL, so the user can easily copy a link to the current page, but it uses location.replace, so that the user doesn't have to continuously press "back" to get to the previous page, which could be unintuitive for some users. If a user clicks on somewhere in the TOC, and then presses back, they should still be directed back to the other part of the page they came from. This commit should not affect that.
ghost
assigned
gfranko
added a commit
that referenced
this pull request
Sep 18, 2013
Change scrollHistory to use window.location.replace
|
Thank you for the update (both dev and master are updated)! I'm happy the plugin has worked well for you =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user visited a page with scrollHistory on, and scrolled down
the page, in order to get back to the previous page, they would have
had to click back in their browser many, many times.
This commit fixes that, so that as the user scrolls, the hash is
added to the URL, so the user can easily copy a link to the current
page, but it uses location.replace, so that the user doesn't have to
continuously press "back" to get to the previous page, which could
be unintuitive for some users.
If a user clicks on somewhere in the TOC, and then presses back,
they should still be directed back to the other part of the page
they came from. This commit should not affect that.
(By the way, thanks again for the awesome plugin! Saved me SO much time and work.)