Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Do not use "amqp" in the library name #55

Closed
kjnilsson opened this issue Feb 13, 2023 · 4 comments
Closed

Suggestion: Do not use "amqp" in the library name #55

kjnilsson opened this issue Feb 13, 2023 · 4 comments
Labels
documentation Improvements or additions to documentation Stale

Comments

@kjnilsson
Copy link

Nice work.

As far as I can see this library doesn't implement the ratified AMQP version (1.0) but instead the legacy version (0.9.1) that RabbitMQ uses. I suggest renaming the library not to include a mention of AMQP to avoid confusion.

RabbitMQ is pretty much the only message broker that still uses the legacy version of the protocol which means it can pretty much be considered a proprietary protocol of RabbitMQ.

@michaelklishin
Copy link
Contributor

Therefore it can be one of

  1. amqp091-rust similarly to https://github.com/rabbitmq/amqp091-go
  2. A variation on various species of rabbits, or the word "rabbit" in various languages
  3. rabbitmq-rust-client or something like that

@gftea gftea added the documentation Improvements or additions to documentation label Feb 14, 2023
@gftea
Copy link
Owner

gftea commented Feb 15, 2023

changing the name is troublesome now since we have release v1.0 and it is used in production.
I would add info in readme that it is for 0-9-1 protocol

@cdbennett
Copy link

cdbennett commented Feb 15, 2023

I see the point of this suggestion, it's valid. But some of the suggested names are cumbersome. At least 'amqprs' is short and the crate name matches the module name you refer to in Rust. Also it seems quite clear from the crate description that it's for RabbitMQ and AMQP 0-9-1 (from crates.io search result) so I doubt anyone is going to think it's for AMQP 1.0:

image

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Mar 18, 2023
@gftea gftea closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Stale
Projects
None yet
Development

No branches or pull requests

4 participants