Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization of Module #32

Closed
kvark opened this issue Mar 16, 2020 · 2 comments · Fixed by #125
Closed

Serialization of Module #32

kvark opened this issue Mar 16, 2020 · 2 comments · Fixed by #125
Labels
area: infra Project infrastructure kind: feature New feature or request

Comments

@kvark
Copy link
Member

kvark commented Mar 16, 2020

I was thinking that it would be great to be able to save (and load?) RON files by the converter. The joys of RON is that it's very nice to inspect visually (by humans):

  • array elements have index numbers, which is critical for associating them with Handle(xxx) values through the rest of the module
  • nice representation of maps and enums
  • otherwise similar to pretty Debug implementation
  • ability to just tweak it by hand

To get this, we need a serde optional feature, implementation of Serialize+Deserialize for all IR objects, and also gfx-rs/rspirv#123 resolved.

@kvark kvark added kind: feature New feature or request area: infra Project infrastructure labels Mar 16, 2020
@paulkernfeld
Copy link
Contributor

Should this have separate serialize and deserialize features as in gfx-rs/rspirv#123, or is it fine to just have a single serde feature for both?

@kvark
Copy link
Member Author

kvark commented Apr 30, 2020

In general, it would be better to separate serialization from deserialization, since the latter is taking way more compile time. This would also let us avoid conflicting the serde feature with optional dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: infra Project infrastructure kind: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants