Cargo.lock in tree

[Skepfyr]

I flip-flop randomly between believing that Cargo.lock should be included in a library repo, but I thought I'd raise this for discussion seen as it was mentioned in #100. The rust documentation does advise against it (FAQ), but I occasionally see a good argument for it. In general, I think it's probably a good idea to remove it.

[kvark]

I think we should remove it, since this is a Rust library, and the end users will have their own lockfiles.

[antiagainst]

We actually have a binary rspirv-dis in tree. So this repo contains both libraries and binaries using workspaces. I'm not sure how does it plays out? Is it possible to make the lock file dis only?

[kvark]

Let's just keep the lock then.

…

On Oct 13, 2019, at 09:52, Lei Zhang ***@***.***> wrote: We actually have a binary rspirv-dis in tree. So this repo contains both libraries and binaries using workspaces. I'm not sure how does it plays out? Is it possible to make the lock file dis only? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.