sr: Add ray-tracing types and deduce OpPhi type in a consistent way #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
sr-fix-phi-type
branch
from
286a78d
to
56a4c63
Compare
MarijnS95
force-pushed
the
sr-fix-phi-type
branch
from
56a4c63
to
878fa01
Compare
38 tasks
MarijnS95
force-pushed
the
sr-fix-phi-type
branch
from
878fa01
to
7ff6eb9
Compare
Co-authored-by: Erin Power <erin.power@embark-studios.com>
MarijnS95
force-pushed
the
sr-fix-phi-type
branch
from
7ff6eb9
to
b98c80e
Compare
|
@khyperia Thanks! I can move the OpPhi change to a separate PR since squash-merging would make a mess of that history anyway :) |
|
eh, should be fine! pretty sure the change is okay, I just don't know the quirks of SR and can't 100% say it's correct, just 95% :P |
MarijnS95
force-pushed
the
sr-fix-phi-type
branch
from
b98c80e
to
a81ae1c
Compare
|
Was already moving it over to a separate PR, mainly because of that squash-thingy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While randomly trying out
srto see what data would come out of it I ran into these issues, thought it was only fair to submit the fixes :)