Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen for extinst.glsl.std.450.grammar.json #24

Closed
MaikKlein opened this issue Oct 8, 2017 · 7 comments
Closed

Codegen for extinst.glsl.std.450.grammar.json #24

MaikKlein opened this issue Oct 8, 2017 · 7 comments

Comments

@MaikKlein
Copy link

https://github.com/KhronosGroup/SPIRV-Headers/blob/master/include/spirv/1.2/extinst.glsl.std.450.grammar.json

Should this also be included in the spirv-headers?

@MaikKlein
Copy link
Author

@MaikKlein
Copy link
Author

I have to reopen this issue. How do you lookup an opcode? I only see https://github.com/google/rspirv/blob/master/rspirv/grammar/glsl_std_450.rs

But that doesn't help me if I want to know the opcode for Sqrt. In my project, I am currently defining them manually like this

#[repr(u32)]
pub enum GlslExtId {
    Round = 1,
    Sqrt = 31,
}

Because that is the id that is being used in ext_inst

@MaikKlein MaikKlein reopened this Oct 8, 2017
@antiagainst
Copy link
Collaborator

Acknowledged. There are no way to get the opcode number from the symbolic opcode right now. Will add methods soon. :)

@antiagainst
Copy link
Collaborator

Should be addressed by 1e180a9.

I'll close this. Let me know if more actions are needed. Thanks!

@antiagainst
Copy link
Collaborator

I'll push a new release soon.

@MaikKlein
Copy link
Author

@antiagainst Thanks! Could also push a new version of rspirv?

@antiagainst
Copy link
Collaborator

@MaikKlein: published v0.5.0. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants