Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some bugs #1

Merged
merged 3 commits into from Oct 22, 2011
Merged

Fixed some bugs #1

merged 3 commits into from Oct 22, 2011

Conversation

gintenlabo
Copy link
Contributor

  • std::vector の resize を使っているせいで, Default Constructible ではない型を扱えなかった点
  • const 修飾のせいで C++11 の move 対応が不完全だった点

以上,二点を修正しました.

// 本当は Copy 不可能( Move のみ可能)なクラスも扱えるようにしたかったのですが,挫折…orz

gfx added a commit that referenced this pull request Oct 22, 2011
@gfx gfx merged commit ec210fe into timsort:master Oct 22, 2011
@gfx
Copy link
Member

gfx commented Oct 22, 2011

お、ありがとうございます。

gcc 4.2 / clang 2.9 (MacOSX) で開発したのでstd::moveは未テストでした。
default constructible は完全に見落としてました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants