-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix thread issue for Perl 5.22 or higher #50
Conversation
In original code, mismatching plan error is occurred.
Tests of Text::Xslate are failed with original code. FROM perl:5.22.0-threaded
RUN cpanm -v Mouse
RUN cpanm -v Text::Xslate All tests of Text::Xslates are passed with Mouse with this change. FROM perl:5.22.0-threaded
RUN curl -LO https://cpan.metacpan.org/authors/id/G/GF/GFUJI/Mouse-2.4.2.tar.gz \
&& tar zxvf Mouse-2.4.2.tar.gz \
&& cd Mouse-2.4.2 \
&& curl -LO https://github.com/gfx/p5-Mouse/pull/50.patch \
&& patch -p1 < 50.patch \
&& cpanm --installdeps . \
&& perl Build.PL \
&& ./Build \
&& ./Build test \
&& ./Build install
RUN cpanm -v Text::Xslate (I suppose these Dockerfiles are not good, I don't understand Docker well :-())) |
Looks good. Can you add perl 5.22 to .travis.yml? |
Done |
😱 Perl 5.22.0 is not available yet. |
I reverted |
:( |
Fix thread issue for Perl 5.22 or higher
Changelog diff is: diff --git a/Changes b/Changes index 3459479..96ccf12 100644 --- a/Changes +++ b/Changes @@ -2,6 +2,9 @@ Revision history for Mouse {{$NEXT}} +v2.4.3 2015-08-02T07:10:09Z + - Fix for Perl 5.22.0 or higher(#50) + 2.4.2 2015-04-12T01:22:02Z - Fixed #40; 'use strict' not enabled when 'use 5.010' follows 'use Mouse' - Fixed #39; New warnings in Perl 5.21.x: redundant arguments for sprintf
The use of
I'm by no means an expert here but these changes worked for me in a variety of older environments, at least as far as passing the test suite. |
@pghmcfc Do you have the issue with Mouse v2.4.4 ? Mouse v2.4.3 have the issue which you indicated. I suppose it is fixed at Mouse v2.4.4. |
@syohex, only the issue regarding the need for |
@pghmcfc I fixed at the issue and released v2.4.5. Please check it. |
@syohex, works for me, thanks. |
Please review this change. I don't understand XS well.
I confirmed that test of #29 and tests of
Text::Xslates
are passed with this change.I fixed by reference to Class::Accessor::Inherited::XS.
This is related to #29, #49.