Tui support for highlighting

[JBenda]

The Highlighting groups don't provide any cterm definitions for the TUI.
I found in lua/lightspeed.lua around line 175 the definition of the highlight groups

Is a target of this project to support TUI too?, then I could open a PR with my changes to discuss a possible implementation.

[ggandor]

Sure, we just need to add the corresponding cterm attributes to the group definitions. The question is, should we convert the values to 256 colors then? Or maybe 16?

The .lua file is generated, you can find the relevant part in the Fennel source file here.

[JBenda]

Thanks, I was already wondering how you possibly can keep track of all this _16_ ;)
NeoVIM only supports 16 colors for console because of compatibility.

[JBenda]

In #4 is a simple idea how a solution looks like.
It's mirrored what I have changed in the lightspee.lua to make it work on my machine.

[ggandor]

Thank you :) Yeah, this is pretty much all we need to do. Will look at this tonight, test and tweak the colors, and figure out a good scheme for light background...

There is a makefile included that you could use to compile the Fennel file to the lua folder, just run make after finishing the edits, and then the plugin can be tested locally after re-sourcing.

[JBenda]

Good to know, I never worked with Lua or Fennel before ^^

[clason]

Might I suggest just defining LightspeedFoo highlight groups and letting color schemes / user configs sort out the actual colors? You can link them to standard highlight groups (Search, IncSearch) by default. This should be more portable / extensible and is how, e.g., gitsigns does this.

(Also, TUIs do use guifg if termguicolors is set.)

[ggandor]

Might I suggest just defining LightspeedFoo highlight groups and letting color schemes / user configs sort out the actual colors?

Preaching to the choir: :h lightspeed-highlight.

(Also, TUIs do use guifg if termguicolors is set.)

Yeah, that's why I skipped defining cterm groups, but it would be better to provide defaults for those anyway.

[JBenda]

(Also, TUIs do use guifg if termguicolors is set.)

but this settting breaks many plugins ^^