Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve paper based on JOSS review #17

Closed
aguspesce opened this issue Aug 30, 2021 · 1 comment
Closed

Improve paper based on JOSS review #17

aguspesce opened this issue Aug 30, 2021 · 1 comment

Comments

@aguspesce
Copy link
Member

aguspesce commented Aug 30, 2021

This is a to-do list for the paper, according to the JOSS reviewer:

  • Explain its positioning relative to other software in this space. You don't have to be comprehensive, but please communicate enough about why a researcher would choose this over a representative set of well-known packages.

  • The equations can be formatted with \begin{align} or \begin{gather} rather than a sequence of display maths.

  • Use other solver in the examples:
    " I see the acknowledgement mentions multigrid, but the van Keken benchmark is configured to use MUMPS. A note on solvers would be useful (even if the intent is that expert users tune using PETSc options)".

  • Mention that in a 3D version will be developed:
    "The paper also doesn't mention whether it supports 3D problems and at what scale it has been used. The code isn't entirely helpful in that "future 3d version" appears in comments, while some functions say they are 3d."

openjournals/joss-reviews#3551

@aguspesce aguspesce changed the title Improve paper according to rewier Improve paper based on JOSS review Aug 30, 2021
@aguspesce
Copy link
Member Author

This issue was solved by #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant