Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary EL parsing #5

Open
ggeorgovassilis opened this issue Jul 3, 2018 · 2 comments
Open

Avoid unnecessary EL parsing #5

ggeorgovassilis opened this issue Jul 3, 2018 · 2 comments

Comments

@ggeorgovassilis
Copy link
Owner

Text (e.g. <node>text</node>) and attribute values (e..g <a attribute="value">) are evaluated by EL with every rendering invocation; it is probably faster to determine during parsing which values contain EL and submit only those for evaluation.

@ggeorgovassilis
Copy link
Owner Author

This ticket should be substantiated with profiling information

@ggeorgovassilis
Copy link
Owner Author

idea: add a boolean variable (or maybe subclass?) that is initialised during node creation to "true" if text contains an EL expression; rendering could then simply check that variable. As always: profile the alternatives to prove that they are useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant