Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download model gguf file from hf #6085

Closed
phymbert opened this issue Mar 15, 2024 · 2 comments · Fixed by #6098
Closed

Download model gguf file from hf #6085

phymbert opened this issue Mar 15, 2024 · 2 comments · Fixed by #6098
Assignees
Labels
enhancement New feature or request

Comments

@phymbert
Copy link
Collaborator

phymbert commented Mar 15, 2024

Motivation

Since GGUF is officially supported on huggingface <3, '--model' might check for local path then fall back to hf repo id.
If a '--file' is provided it should override default for f16.

References

@phymbert phymbert added the enhancement New feature or request label Mar 15, 2024
@phymbert phymbert self-assigned this Mar 15, 2024
@phymbert
Copy link
Collaborator Author

@ggerganov thoughts ?

@ggerganov
Copy link
Owner

We considered this at some point (#4735) but it opens a lot of security concerns due to the core library having to execute commands. So we settled with #5501 which should be good enough for most cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants