Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add points: u32 parameter to graphics::Font::default_font func #375

Closed
ozkriff opened this issue May 9, 2018 · 3 comments
Closed

Add points: u32 parameter to graphics::Font::default_font func #375

ozkriff opened this issue May 9, 2018 · 3 comments

Comments

@ozkriff
Copy link
Contributor

ozkriff commented May 9, 2018

Or create another function like graphics::Font::default_font_with_points(points: u32) -> GameResult<Self>.

@Ratysz
Copy link
Contributor

Ratysz commented May 9, 2018

Ideally, we'd allow the user app to override default font (via config or builder) entirely during context creation. This is very relevant to #362, and I have a few ideas how to handle it better - but the changes have to be sanity-checked and merged first.

@icefoxen
Copy link
Contributor

icefoxen commented May 9, 2018

I like Ratysz's idea. But now that I think of it, default_font_with_points() or such would be pretty easy to make... But then we'd need default_fonts_with_px() as well. Might be nice to separate "a font with size information" from "raw font data" somehow...

Really the only reason I included a default font at all is to make life easy for writing debug text.

@icefoxen icefoxen added this to the 0.5 milestone May 9, 2018
@icefoxen
Copy link
Contributor

This is now obsolete since gfx_glyph takes size information when text is drawn, not when the font is loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants