Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Wait Active timeout and retry interval to be configurable #185

Closed
nathairtras opened this issue Dec 1, 2014 · 2 comments · Fixed by #192
Closed

Allow Wait Active timeout and retry interval to be configurable #185

nathairtras opened this issue Dec 1, 2014 · 2 comments · Fixed by #192
Assignees
Milestone

Comments

@nathairtras
Copy link

The hard-coded value of 3.33 minutes is too short for our environment. Allowing the end user to configure this value would help in dealing with less-than-optimal hosting arrangements. Allowing the retry to be increased is nice in cases where you know you will need to wait for a while - it could either be set dynamically based upon the timeout, or manually entered.

Impacted file:
source/lib/vagrant-openstack-provider/action/wait_active.rb

Vagrant 1.6.5
vagrant-openstack-provider 0.6.0

@julienvey julienvey added this to the 0.7 milestone Dec 2, 2014
@julienvey
Copy link
Collaborator

Sure, both retry_interval and timeout should be configurable.
Not only for WaitForServerToBeActive but also for WaitForServerToStop

This is also related to a discussion we had in #170 where we planned to refactor these actions in a more generic WaitFor..X..ToBe..Y..

@ggiamarchi ggiamarchi self-assigned this Jan 9, 2015
@ggiamarchi ggiamarchi modified the milestones: 0.7, 0.6.1 Jan 16, 2015
@vinsh
Copy link
Contributor

vinsh commented Feb 4, 2015

Good work on this feature! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants