Skip to content
This repository has been archived by the owner on Mar 12, 2022. It is now read-only.

Allow user to customize chromosome label in probe query script #20

Closed
ggirelli opened this issue Sep 12, 2019 · 4 comments · Fixed by #30
Closed

Allow user to customize chromosome label in probe query script #20

ggirelli opened this issue Sep 12, 2019 · 4 comments · Fixed by #30
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@ggirelli
Copy link
Owner

Is your feature request related to a problem? Please describe.
The query script(s) require to specify a region in the chrN:XXX,YYY format, which forces the user to label chromosomes (or fragments) with the "chr" prefix, which can be useless in certain scenarios.

Describe the solution you'd like
Add a new script argument where the regular expression can be defined by the user.

@ggirelli ggirelli added the enhancement New feature or request label Sep 12, 2019
@ggirelli
Copy link
Owner Author

ggirelli commented Feb 3, 2021

Also remove the prefix 'chr' from the default regular expression parsing the region string.

@ggirelli ggirelli self-assigned this Feb 3, 2021
@ggirelli ggirelli added this to To do in v2.0.4 Feb 3, 2021
@ggirelli ggirelli added this to the v2.0.4 milestone Feb 3, 2021
@ggirelli
Copy link
Owner Author

ggirelli commented Feb 4, 2021

Or, even better, replace the input string to be parsed with three separate input arguments: feature, start and end. This would solve many issues due to parsing and remove the requirement for regexp knowledge from the user.

@ggirelli ggirelli moved this from To do to In progress in v2.0.4 Feb 10, 2021
@ggirelli
Copy link
Owner Author

Implemented the following in v2.0.4 (soon to be released).

Both probe and probe set query scripts have two arguments instead of the previous region:

  • a mandatory "chrom" argument, which is not strictly a chromosome, but any feature in the database
  • a facultative "--region" argument that accepts a start-end string.

When the --region argument is not used, the whole feature is queried.

Also, note that when the --region argument is not used, the feature size is obtained by querying a DAS server. To use the size based on the database oligos use the --no-net option.

v2.0.4 automation moved this from In progress to Done Feb 10, 2021
@ggirelli
Copy link
Owner Author

Switched from

a facultative "--region" argument that accepts a start-end string.
to a facultative --region argument that accepts two space-separated int values: start and end respectively. If start and end coincide, the effect is the same as when --region is omitted.

@ggirelli ggirelli reopened this Feb 10, 2021
v2.0.4 automation moved this from Done to In progress Feb 10, 2021
v2.0.4 automation moved this from In progress to Done Feb 10, 2021
@ggirelli ggirelli linked a pull request Feb 11, 2021 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant