Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bip_metainfo: API Type Changes #72

Closed
GGist opened this issue Apr 11, 2017 · 1 comment
Closed

bip_metainfo: API Type Changes #72

GGist opened this issue Apr 11, 2017 · 1 comment

Comments

@GGist
Copy link
Owner

GGist commented Apr 11, 2017

Will have to double check that we aren't breaking spec, but in general, having to deal with the current types has been painful in downstream libraries (like bip_disk).

  • File::length() should return a u64
  • InfoDictionary::piece_length() should return a u64

On a not spec breaking related note:

  • File::paths() should return a &Path (so we should allocate a PathBuf internally)
@GGist
Copy link
Owner Author

GGist commented Apr 22, 2017

Closed 3794dbb

@GGist GGist closed this as completed Apr 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant