Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing wait_time=timeout in 'I should not see "text" within {timeout} seconds' #4

Closed
moreandres opened this issue Sep 3, 2013 · 1 comment

Comments

@moreandres
Copy link

It seems to me that there is a missing wait_time=timeout argument to the code below.

@step(u'I should not see "{text}" within {timeout:d} seconds')
def should_not_see_within_timeout(context, text, timeout):
assert context.browser.is_text_not_present(text), u'Text was found'

The positive tests seems to be using it OK.

@step(u'I should see "{text}" within {timeout:d} seconds')
def should_see_within_timeout(context, text, timeout):
assert context.browser.is_text_present(text, wait_time=timeout), u'Text not found'

I've checked here that the wait_time can be used with the negative text present method.

http://splinter.cobrateam.info/docs/matchers.html

@ggozad
Copy link
Owner

ggozad commented Sep 4, 2013

You are right of course, would you like to make a PR to take the credit?

@ggozad ggozad closed this as completed in 71f90e5 Sep 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants