-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions indicate thumbnails are 350px wide but they are actually 344px wide #37
Comments
@mjskay Thanks for this observation. Please create a pull request to address this and I'll merge it :-) |
Happy to. What solution do you prefer?
|
I think option 2 would suffice. |
@mjskay |
The instructions suggest uploading an image that will look best on a retina display at 350 pixels wide, but the images are actually displayed at a width of 344 pixels:
This appears to be because the div containing the image is 350 pixels wide, but has a 3 pixel padding.
Unless I am mistaken on the mapping of web-pixel-size to retina-pixel-size, taking the instructions as given one would assume you should upload a 700 pixel wide image (twice the stated resolution to be optimal for a retina display), but should probably instead use a 644 pixel wide image given the current layout.
Could either the instructions or the CSS be adjusted so that they match?
The text was updated successfully, but these errors were encountered: