Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions indicate thumbnails are 350px wide but they are actually 344px wide #37

Closed
mjskay opened this issue Mar 11, 2018 · 4 comments

Comments

@mjskay
Copy link
Contributor

mjskay commented Mar 11, 2018

The instructions suggest uploading an image that will look best on a retina display at 350 pixels wide, but the images are actually displayed at a width of 344 pixels:

gallery-344px-image

This appears to be because the div containing the image is 350 pixels wide, but has a 3 pixel padding.

Unless I am mistaken on the mapping of web-pixel-size to retina-pixel-size, taking the instructions as given one would assume you should upload a 700 pixel wide image (twice the stated resolution to be optimal for a retina display), but should probably instead use a 644 pixel wide image given the current layout.

Could either the instructions or the CSS be adjusted so that they match?

@Emaasit
Copy link
Member

Emaasit commented Mar 12, 2018

@mjskay Thanks for this observation. Please create a pull request to address this and I'll merge it :-)

@mjskay
Copy link
Contributor Author

mjskay commented Mar 12, 2018

Happy to. What solution do you prefer?

  1. Leave the layout as-is, but change the instructions to ask for images that work best for retina at 344x294 (i.e., some multiple of this size >= 2 will yield best results, such as 688x588).

  2. Remove the 3px padding from the layout (images would go right to the inner edge of the boxes, but box sizes would stay as-is).

  3. Increase the box width and height by 6px to compensate for the padding.

  4. Something else?

@Emaasit
Copy link
Member

Emaasit commented Mar 25, 2018

I think option 2 would suffice.

@yutannihilation
Copy link
Member

@mjskay
I think I've fixed the padding. Could you confirm if this is the proper fix when you have a chance? I'm not an expert of CSS...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants