Much better

ggreer · May 19, 2012 · 3982e32 · 3982e32
1 parent 66952f5
commit 3982e32
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 39 deletions.
diff --git a/background.js b/background.js
@@ -1,17 +1,19 @@
-var active_urls = [];
-
 function check_url(tab_id, change_info, tab) {
-  var i;
+    var active_urls = JSON.parse(localStorage.urls);
-  for (i = 0; i < active_urls.length; i++) {
+    var i;
-    if(tab.url === active_urls[i]) {
+
-      chrome.pageAction.show(tab_id);
+    chrome.pageAction.hide(tab_id);
-      break;
+
+    for (i = 0; i < active_urls.length; i++) {
+        if(tab.url === active_urls[i]) {
+            chrome.pageAction.show(tab_id);
+            break;
+        }
+    }
+
+    if(tab.url === "https://reach-bb.k1k.me/waterfall") {
+        chrome.pageAction.show(tab_id);
     }
-  }
-  chrome.pageAction.hide(tab_id);
-  if(tab.url === "https://reach-bb.k1k.me/waterfall") {
-    chrome.pageAction.show(tab_id);
-  }
 }
 
 chrome.tabs.onUpdated.addListener(check_url);

diff --git a/options.html b/options.html
@@ -1,12 +1,10 @@
 <html>
 <head>
-<title>Options</title>
+    <title>Options</title>
 </head>
 <script type="text/javascript" src="options.js"></script>
 <body>
-    <div id="url_list">
+    <textarea id="url_list"></textarea>
-        <input class="url" type="text" />
+    <button id="save">Save</button>
-    </div>
-<button id="save">Save</button>
 </body>
 </html>
diff --git a/options.js b/options.js
@@ -1,36 +1,20 @@
 function restore() {
     var i;
-    var url_input;
+    var url_list_node = document.getElementById("url_list");
-    var url_list_node;
+    var urls;
-    var urls = [];
 
     if (localStorage.urls) {
         urls = JSON.parse(localStorage.urls);
     }
 
-    url_list_node = document.getElementById("url_list");
+    url_list_node.value = urls.join("\n");
-
-    for (i=0; i<urls.length; i++) {
-        url_input = document.createElement("input");
-        url_input.value = urls[i];
-        url_input.setAttribute("class", "url");
-        url_input.setAttribute("type", "text");
-        url_list_node.insertBefore(url_input);
-        console.log("loaded", urls[i]);
-    }
 }
 
 function save() {
-    var i;
+    var url_list_node = document.getElementById("url_list");
-    var url;
+    var urls = url_list_node.value.split("\n");
-    var url_elements = document.getElementsByClassName("url");
-    var urls = [];
-
-    for (i=0; i<url_elements.length; i++) {
-        urls.push(url_elements[i].value);
-        console.log("stored", url_elements[i].value);
-    }
 
+    console.log("saving", urls);
     localStorage.urls = JSON.stringify(urls);
 }