Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silver searcher does not go up the directory structure when checking .gitignore #428

Closed
pavellishin opened this issue Jun 12, 2014 · 3 comments
Labels

Comments

@pavellishin
Copy link

We are ignoring build directories.

[2014-06-12 16:33:12] pavel.lishin@plishin:/gitwork/aproject
# ag 'target/' .gitignore
35:target/

And ag respects that from within my project's root folder.

[2014-06-12 16:33:35] pavel.lishin@plishin:/gitwork/aproject
# ag --js rtReviews
app/api/src/main/resources/web/test/unit/model/user-submission-controller-spec.js
14:            rtReviews: false,

But if I go further into the project file structure, it doesn't care.

[2014-06-12 16:33:42] pavel.lishin@plishin:/gitwork/aproject
# cd app
[2014-06-12 16:33:45] pavel.lishin@plishin:/gitwork/aproject/app
# ag --js rtReviews
api/src/main/resources/web/test/unit/model/user-submission-controller-spec.js
14:            rtReviews: false,

api/target/classes/web/test/unit/model/user-submission-controller-spec.js
14:            rtReviews: false,

Much like git searches upwards through a directory structure to check for .gitignore files, I believe ag should as well.

@AlexRiedler
Copy link

any work on this, I find this really annoying...

@ggreer ggreer added the ignore label Sep 26, 2014
@theospears
Copy link
Collaborator

I believe this is the same as #144 (which has some conversation)

@ggreer
Copy link
Owner

ggreer commented Nov 14, 2014

Yep. This is a duplicate of #144.

@ggreer ggreer closed this as completed Nov 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants