Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit 4602: dom.enable_resource_timing #813

Closed
Thorin-Oakenpants opened this issue Oct 11, 2019 · 1 comment
Closed

revisit 4602: dom.enable_resource_timing #813

Thorin-Oakenpants opened this issue Oct 11, 2019 · 1 comment

Comments

@Thorin-Oakenpants
Copy link
Contributor

Keep an eye on what gk does with this

https://trac.torproject.org/projects/tor/ticket/27268#comment:18

With RFP set, all of these timestamps will be clamped/jittered. Additionally, RFP has the behavior of setting dom.enable_performance to false (so you don't need to set that pref.)

However RFP does not have the same behavior for dom.enable_resource_timing - so you may want to disable that explicitly.

@earthlng
Copy link
Contributor

AFAICT I think he's wrong and dom.enable_resource_timing is fully covered by RFP.

According to this you always start a resource timing with some form of performance.getEntriesByType("resource") and that returns an empty array if either RFP is enabled or dom.enable_resource_timing is set to false.

Yes, RFP doesn't exactly have the behavior of disabling the pref like it does for dom.enable_performance but that's irrelevant because it instead hooks into getEntriesByType and returns an empty array instead of the list of resources available for timing.

I'd ping Tom but I forgot his GH handle, again ;)
Can you add him to the list of contributors or something so that his GH name comes up by typing @t ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants