Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JWT decoding error should return unauthorized #303

Closed
sercanov opened this issue Jan 16, 2017 · 2 comments
Closed

JWT decoding error should return unauthorized #303

sercanov opened this issue Jan 16, 2017 · 2 comments

Comments

@sercanov
Copy link
Contributor

In isAuthenticated.js when jwt authenticating fails, sends it to res.negotiate and return 500, i think it should be return unauthorized no matter what the cause is for decoding token. Don't you think so ? ^^
@ghaiklor
Copy link
Owner

@sercanov feel free to create a PR for it 👍
We already added 401 error - https://github.com/ghaiklor/generator-sails-rest-api/blob/dev/generators/authentication/templates/api/policies/isAuthenticated.js#L12

@sercanov
Copy link
Contributor Author

sure I will !

This was referenced Jan 17, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghaiklor @sercanov