recursion.json test not available

[ayushbindlish]

Hi @ghandic

I see a recursion.json in src/tests/data, but I do not see a test for it. Is it supported by jsf? Also, is $ref:"#" supported?

Thanks.

[ghandic]

It isn't supported yet, there's an issue open for it I believe - recursion.

I don't believe # is supported yet either

[ayushbindlish]

Can we expect to get that functionality soon?

[ghandic]

I'm open to discussing how we could build it, I think when I last was working on this I figured I'd have to do a redesign to implement it... again PR is welcome 😁

[ayushbindlish]

I myself did not look at the code for that functionality. Would you kindly divulge the implementation details for this functionality and I will try to implement it.
Also, which draft is supported here? is it draft 4 or 7, or some other?

[ghandic]

I was working towards draft 2020-12, there are a lot of features to the overall specification so there will always be more to do! I was also primarily trying to tackle the most common cases and less of the edge cases up front. If theres something in particular you were looking for that you believe isnt supported then I'm happy to discuss it on here. Also feel free to add failing tests for any JSON schema that isnt supported currently so that the functionality can be built! 😄

In terms of recursion, I spent a few hours while initially building the package to try to implement it. There were some circular dependencies that I kept hitting, it is definitely possible to accomplish but will need to add thought into it on this discussion. Particularly, when we generate how deep to go with the recursive random data generation.

[ghandic]

I'll close this thread and move it to the enhancement issue created previously #13