Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV column Separator parameter #10

Merged
merged 5 commits into from Mar 9, 2020
Merged

CSV column Separator parameter #10

merged 5 commits into from Mar 9, 2020

Conversation

farrukhsubhani
Copy link
Contributor

Please check this and anything else required as I am editing all on github so there can be mistake or missing code.
Thanks for all the help.
This should close #9

Added default
Added check to see if it exist in arguments otherwise use default
Due to default value it would be available as , now.
@gharibi
Copy link
Owner

gharibi commented Mar 8, 2020

There is a small problem with the default params in HERE.

Your default is ColumnSeparator whereas it should be columnSeparator. Could you please refactor it and open the PR again? thanks.

@farrukhsubhani
Copy link
Contributor Author

Thanks, it was my phone capitalised first letter and i did not notice.

@farrukhsubhani
Copy link
Contributor Author

Thanks for all your help, just wanted to make sure that:

  1. Headers if present should also use same separator
  2. Dont forget to send changes to minified file

Let me know if there is anything I can do to help with.

@gharibi
Copy link
Owner

gharibi commented Mar 9, 2020

Great, thanks. Sure, I will check and do it tonight.

@gharibi gharibi merged commit ae2147b into gharibi:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override CSV Column Separator
2 participants