New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename detection in status() #30
Conversation
This is still a WIP, figuring out exactly how to handle all the possibilities. |
I merged my |
Rebased. |
So, if I understand this correctly, now status() returns something like: {
'file1' => {
'flags' => [...]
},
'file2' => {
'flags' => [...],
'index' => {
'old_file' => ...
}
},
'file3' => {
'flags' => [...],
'worktree' => {
'old_file' => ...
}
}
} Where (also, I'm not sure why |
That is exactly what it will return. Looks like there is still a bug in I'll move the |
I'm almost done with this PR and busy with #31, should finish it this week. Is it possible to do a new release later this week? I would like to synchronise internally with all the changes that are now upstream. |
Sure, I can do a release whenever you are ready. |
I think this one is done :) |
Merged, thanks! |
I've implemented a WIP for rename detection. Please have a look at it and let me know what you think.
It's actually a little bit tricky, considering that a file may be renamed in the index and in the working tree at the same time. The current data model where we return ex.
{'file' => [ '*_modified']}
cannot capture renames.