-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using :example_group from metadata is deprecated warning [Rspec] #8
Comments
Thanks for looking into this. I would suggest looking at vcr's implementation of this (on which this recursive code was originally based). I bet they have found the right way around it. |
@ghempton Done! Vcr's current implementation doesn't generate this warning. Here is the PR ^ |
@ghempton, can you cut a new version on ruby gems which includes this change? |
Sure |
Just pushed 0.0.5 |
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey @ghempton!
Thank you for developing this gem! It's been very useful so far. 馃憤
The only issue that I've found is that it shows this warning:
This happens because Rspec has deprecated the usage of
metadata[:example_group]
- See: rspec/rspec-rails#1035I tried to write a PR to fix this but I couldn't find a decent way to keep the current tree structure for the recordings.
Instead of using the recursive code that generates the nested folder, I could write an implementation that uses
metadata[:full_description]
to generate the recording file. The problem with this solution is that it wouldn't be backwards compatible. :(What do you think?
Thanks!
The text was updated successfully, but these errors were encountered: