Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] React Async DevTools (closes #43) #44

Merged
merged 37 commits into from Jul 3, 2019
Merged

[wip] React Async DevTools (closes #43) #44

merged 37 commits into from Jul 3, 2019

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Apr 22, 2019

  • Extend React Async API to allow external control over internal state (published separately in v6.1.0)
  • Setup Storybook for interactive development
  • Implement DevTools UI
  • Add debugLabel prop to add human readable promise label
  • Hook up DevTools to every instance of <Async> and useAsync()
  • Update documentation
  • Setup multi-package repo

@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #44 into master will decrease coverage by 0.41%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   99.65%   99.23%   -0.42%     
==========================================
  Files           7        9       +2     
  Lines         582      657      +75     
  Branches      122      143      +21     
==========================================
+ Hits          580      652      +72     
- Misses          2        5       +3
Impacted Files Coverage Δ
packages/react-async/src/specs.js 99.67% <ø> (ø)
packages/react-async/src/helpers.js 100% <ø> (ø)
packages/react-async/src/status.js 100% <ø> (ø)
packages/react-async/src/propTypes.js 100% <ø> (ø)
packages/react-async/src/reducer.js 100% <ø> (ø)
packages/react-async/src/useAsync.js 98.86% <100%> (ø)
packages/react-async/src/Async.js 100% <100%> (ø)
packages/react-async-devtools/src/components.js 100% <100%> (ø)
packages/react-async-devtools/src/index.js 94.64% <94.64%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60cf7a0...7cd46da. Read the comment docs.

@ghengeveld ghengeveld merged commit 201f01b into master Jul 3, 2019
@ghengeveld ghengeveld deleted the devtools branch July 3, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant