Remove WampBuilder.setActionMapping()

[trumpetinc]

Remove WampBuilder.setActionMapping() and DefaultRPCManager.setActionMapping() methods.

Instead, have an addAll() method that copies the values from an existing mapping.

The current implementation allows a user to accidentally destroy previous configuration.

[ghetolay]

We can add an addAll() method but this won't replace the setter need, this is 2 different use case.
setActionMapping() allow user to provider it's own ActionMapping implementation.

For DefaultRPCManager, Initially ActionMapping was a constructor argument but I guess this was causing troubles. Also if user want to manipulate directly DefaultRPCManager he should understand how it works and it's at his own risk (we'll provide complete javadoc).

About the Builder it's suppose to make things easy for the user so I've already thought about :

public RPCManager newRPCManager();
public RPCManager newRPCManager(ActionMapping mapping);

and remove setActionMapping(). That's why there is a javadoc comment.

The jsr356 version is a first draft. Especially WampBuilder, this was done pretty fast and there was no real design thinking behind it. For example embedding multiple builder may be a bad choice.

What we really need is a design reflexion about the whole class and usage more than just a specific method.

[trumpetinc]

ok - do you want to open a new issue to discuss the WampBuilder design/etc... or discuss it here?