Handling kebab-cased relationship

[GIANTCRAB]

Hello,

Thanks for this amazing library. I've been using it for the past few days and encountered an issue with regards to relationship. I'm currently using version 7.1.2 with Angular v8.

In the Campaign model, I've got several types

  campaigns
  campaign-proposals
  companies

The following is my model with a one-to-many relationship

@JsonApiModelConfig({
  type: 'campaigns'
})
export class Campaign extends JsonApiModel {
  @HasMany()
  companies: Company[];

  @HasMany()
  campaignProposals: CampaignProposal[];
}

When retrieving record, I checked that the network has received it:

Company was parsed correctly but the console output did not give me campaignProposals:

Am I doing something wrong here? Thank you!

[GIANTCRAB]

I figured. A simple workaround this would be the following:

@JsonApiModelConfig({
  type: 'campaigns'
})
export class Campaign extends JsonApiModel {
  @HasMany()
  companies: Company[];

  @HasMany()
  'campaign-proposals': CampaignProposal[];
}

If there's a better approach to this, please let me know. Thanks

[hpawe01]

Have a look at this issue: #210

You could do @HasMany({key: 'campaign-proposals'}) and just use your custom property (like campaignProposals)

[GIANTCRAB]

Thanks @hpawe01

Can I do a PR to update the README with this info? I think it'll be rather useful

[hpawe01]

Sure, PRs that improve the README are definitely welcome altough I am not in the position to decide this, but more @safo6m or @HennerM. But I am sure they be glad as well, so just create it and wait for comments and approval.