Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Unclear behavior of n_patches argument in patch/labels_patch.py #5

Open
1 task done
sphamba opened this issue Aug 28, 2023 · 0 comments
Open
1 task done

[BUG] Unclear behavior of n_patches argument in patch/labels_patch.py #5

sphamba opened this issue Aug 28, 2023 · 0 comments
Labels
invalid This doesn't seem right

Comments

@sphamba
Copy link
Collaborator

sphamba commented Aug 28, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

In patch/labels_patch.py, the patch_counter variable is not incremented correctly when grouped_by_labels_id is True.

Originally posted by @sphamba in #4 (comment)

Expected Behavior

Right now we increment the counter by 1 while:

  • for a given label multiple patches can be extracted when tiling or sliding
  • we could also have the case where no patch is extracted for a label (maybe with a custom center on method?)

Originally posted by @ghiggi in #4 (comment)

Steps To Reproduce

No response

Environment

No response

Anything else?

No response
@sphamba sphamba added the bug Something isn't working label Aug 28, 2023
@sphamba sphamba added invalid This doesn't seem right and removed bug Something isn't working labels Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sphamba @ghiggi