fix(pagination): should be able to toggle Pagination

- we should be able to toggle Pagination and it should still work as expected after showing it again - the previous code was disposing of the Pagination Service when hiding (disposing) the Pagination Component but that shouldn't be the case, disposing of the Service should strictly be handled by the Angular-Slickgrid-Component
ghiscoding · Jun 28, 2021 · 4272b18 · 4272b18
1 parent d933829
commit 4272b18
Show file tree

Hide file tree

Showing 4 changed files with 141 additions and 115 deletions.
diff --git a/src/app/modules/angular-slickgrid/components/slick-pagination.component.ts b/src/app/modules/angular-slickgrid/components/slick-pagination.component.ts
@@ -131,8 +131,6 @@ export class SlickPaginationComponent implements OnDestroy, OnInit {
   }
 
   dispose() {
-    this.paginationService?.dispose();
-
     // also unsubscribe all Angular Subscriptions
     this.subscriptions = unsubscribeAllObservables(this.subscriptions);
   }